Move per-function debuginfo methods from codegen to builder methods#158560
Merged
Conversation
It isn't called from cg_ssa.
These functions are scoped to a single codegened function
These functions are scoped to a single codegened function
Collaborator
|
|
rustbot
added
A-LLVM
Collaborator
|
r? @Kivooeo rustbot has assigned @Kivooeo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Kivooeo
reviewed
Jun 30, 2026
Member
Author
Indeed. I don't think the order matters. |
Kivooeo
approved these changes
Jun 30, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
…uwer Rollup of 5 pull requests Successful merges: - #158600 (Fix `rustc --unpretty=expanded` emit of `[const] [unsafe] impl Trait for`) - #158560 (Move per-function debuginfo methods from codegen to builder methods) - #158563 (Test(lib/net): Fix `hostname_smoketest` for Win7) - #158571 (Update books) - #158592 (tests: only run `lexical-scope-in-match.rs` for LLDB >= 21)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
…uwer Rollup of 5 pull requests Successful merges: - #158600 (Fix `rustc --unpretty=expanded` emit of `[const] [unsafe] impl Trait for`) - #158560 (Move per-function debuginfo methods from codegen to builder methods) - #158563 (Test(lib/net): Fix `hostname_smoketest` for Win7) - #158571 (Update books) - #158592 (tests: only run `lexical-scope-in-match.rs` for LLDB >= 21)
rust-timer
added a commit
that referenced
this pull request
Jun 30, 2026
Rollup merge of #158560 - bjorn3:ssa_refactor_debuginfo, r=Kivooeo Move per-function debuginfo methods from codegen to builder methods In cg_clif the debuginfo for the function we are currently codegening is stored in `FunctionDebugContext`, which is stored in the `FunctionCx`, not in the per-cgu `DebugContext`.
bjorn3
pushed a commit
to bjorn3/miri
that referenced
this pull request
Jul 1, 2026
…uwer Rollup of 5 pull requests Successful merges: - rust-lang/rust#158600 (Fix `rustc --unpretty=expanded` emit of `[const] [unsafe] impl Trait for`) - rust-lang/rust#158560 (Move per-function debuginfo methods from codegen to builder methods) - rust-lang/rust#158563 (Test(lib/net): Fix `hostname_smoketest` for Win7) - rust-lang/rust#158571 (Update books) - rust-lang/rust#158592 (tests: only run `lexical-scope-in-match.rs` for LLDB >= 21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cg_clif the debuginfo for the function we are currently codegening is stored in
FunctionDebugContext, which is stored in theFunctionCx, not in the per-cguDebugContext.